vdiravka commented on a change in pull request #1640: DRILL-7038: Queries on
partitioned columns scan the entire datasets
URL: https://github.com/apache/drill/pull/1640#discussion_r258904667
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java
##########
@@ -224,6 +224,33 @@ public static boolean isPartitionColumn(String
partitionDesignator, String path)
return Arrays.asList(diffDirectoryNames);
}
+ public static List<String> listPartitionValuesDirectory(String dirPath,
String root) {
Review comment:
It copies 90% of `listPartitionValues()` method. Could you just pass some
boolean flag to the old method, for example `hasDirsOnly` as
[here](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSFilePartitionLocation.java#L29)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
