Ben-Zvi commented on issue #1650: DRILL-6707: Allow Merge-Join batch resizing to go smaller than current outgoing row count URL: https://github.com/apache/drill/pull/1650#issuecomment-467322764 @sohami - an updated version was pushed - The original Merge-Join check was restored, and the two changes you proposed are in: `adjustOutputRowCount()` now rounds to the NEXT power of two, and the `updateInternal()` caps the returned result at the current batch size (so no need to reallocate, etc.) The other code changes are just debug and cosmetics. Note that two unit test files had failures due to the "rounding up": `testUnnestLimitBatchSize()` - where I removed the last comment and matched the prior comment. And in `TestOutputBatchSize` - many similar adjustments to expected (max) batch size and (min) number of batches (the increase in batch size led to fewer batches).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
