vvysotskyi commented on issue #1656: DRILL-7056: Drill fails with NPE when starting in distributed mode & … URL: https://github.com/apache/drill/pull/1656#issuecomment-467374582 @kkhatua, please add the unit test (you may use `TestGracefulShutdown.testDrillbitWithSamePortContainsShutdownThread` as an example). Also, in `WebServer` `tmpJavaScriptDir` is marked for deletion (`tmpJavaScriptDir.deleteOnExit()`) and this directory is also deleted in the `close()` method. Please either remove `deleteOnExit()` call or remove `FileUtils.deleteDirectory(tmpJavaScriptDir);`. If `FileUtils.deleteDirectory(tmpJavaScriptDir);` will be left, I think it makes sence to replace it with `FileUtils.deleteQuietly(tmpJavaScriptDir);` to avoid possible errors in `close()` method. And finally please order the methods in `WebServer` according to JCC, since `getTmpJavaScriptDir()` method is added before the constructor in your fix for DRILL-5735.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
