vvysotskyi commented on a change in pull request #1646: DRILL-6852: Adapt
current Parquet Metadata cache implementation to use Drill Metastore API
URL: https://github.com/apache/drill/pull/1646#discussion_r260351186
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectIntoScanRule.java
##########
@@ -61,12 +61,12 @@ protected boolean skipScanConversion(RelDataType
projectRelDataType, TableScan s
public static final RelOptRule DRILL_LOGICAL_INSTANCE =
new DrillPushProjectIntoScanRule(LogicalProject.class,
DrillScanRel.class,
- "DrillPushProjIntoDrillRelScan");
+ "DrillPushProjectIntoScanRule");
Review comment:
No, it is useful to have a description of the rule which contains the name
of the class to find the rule reading the logs for example. So I will change it
to `DrillPushProjectIntoScanRule:logical`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
