sohami commented on issue #1652: DRILL-7046: Support for loading and parsing new RM config file URL: https://github.com/apache/drill/pull/1652#issuecomment-467674626 @paul-rogers - For question related to new configuration file. - Usually number of configurations for a new feature in Drill ranges from 5-6 at max. For RM the configuration is extensive to provide lots of flexible options for an admin. As contrast to earlier queue now admin can configure as many queues needed and hierarchy of ResourcePool can be both deep and wide. Each ResourcePool have options to configure selectors, memory resource percentage, queue, etc. Given the configuration is so huge I think it calls for a separation into it's own file. - Also when RM is enabled then only these configurations will be needed. If RM related configuration is present in drill-override.conf with feature disabled then still Drill will load all of it in memory which won't happen with this separate file in place. This PR only add's support for the new RM configuration parsing and creating in-memory structures. There are still lots of components which needs to be developed like planner components, scheduler, etc. All the changes will come in phases. I have already added functional spec in the JIRA which has detailed explanation about the configuration. But I have also tried adding `package-info.java` with necessary information. Also I have moved all the files to a new config package under resourcemgr package to represent this PR contains only config changes. Please let me know if it looks sufficient to you. As far as detailed design is concerned you can find the document explaining it in [DRILL-7026](https://issues.apache.org/jira/browse/DRILL-7026) which is parent JIRA of [DRILL-7046](https://issues.apache.org/jira/browse/DRILL-7046).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
