kfaraaz commented on a change in pull request #1634: DRILL-6979: Added
autofocus attribute to username on login page, and to query tex…
URL: https://github.com/apache/drill/pull/1634#discussion_r260564818
##########
File path: exec/java-exec/src/main/resources/rest/login.ftl
##########
@@ -24,15 +24,15 @@
<#macro page_body>
<div class="page-header"></div>
<div align="center" class="table-responsive">
- <form role="form" name="input" action="/j_security_check"
method="POST">
+ <form role="form" name="input" autocomplete="off"
action="/j_security_check" method="POST">
Review comment:
Due to a privacy concern, I would prefer that the browser not remember the
values for such fields that may contain sensitive information (for example, a
unique government identifier or credit card security code), even if the
browser's autocomplete feature is enabled.
Hence, autocomplete="off"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services