vdiravka commented on a change in pull request #1657: DRILL-5603: Replace
String file paths to Hadoop Path
URL: https://github.com/apache/drill/pull/1657#discussion_r261768563
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
##########
@@ -242,16 +238,17 @@ public TableScan createTableScan(List<PartitionLocation>
newPartitionLocation, S
((DrillScanRel) scanRel).getColumns(),
true /*filter pushdown*/);
} else if (scanRel instanceof EnumerableTableScan) {
- return createNewTableScanFromSelection((EnumerableTableScan)scanRel,
newFiles, cacheFileRoot,
+ return createNewTableScanFromSelection((EnumerableTableScan) scanRel,
newFiles, cacheFileRoot,
wasAllPartitionsPruned, metaContext);
} else {
throw new UnsupportedOperationException("Only DrillScanRel and
EnumerableTableScan is allowed!");
}
}
- private TableScan createNewTableScanFromSelection(EnumerableTableScan
oldScan, List<String> newFiles, String cacheFileRoot,
- boolean wasAllPartitionsPruned, MetadataContext metaContext) {
+ private TableScan createNewTableScanFromSelection(EnumerableTableScan
oldScan, List<Path> newFiles,
+ Path cacheFileRoot, boolean wasAllPartitionsPruned, MetadataContext
metaContext) {
final RelOptTableImpl t = (RelOptTableImpl) oldScan.getTable();
+ // TODO: refactor duplicate code
Review comment:
Sure, forgot to solve it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
