Ben-Zvi commented on a change in pull request #1662: DRILL-6825: apply
different hash algorithms to different data types
URL: https://github.com/apache/drill/pull/1662#discussion_r263190668
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
##########
@@ -624,6 +639,27 @@ private void retryAfterOOM(boolean batchAdded) throws
RetryAfterSpillException {
throw new RetryAfterSpillException();
}
+ /**
+ * Return the Hash Value for the row in the Build incoming batch at index:
+ * (Only apply to Hash Aggregate there's no "Build" side -- only one batch
- this one)
+ *
+ * @param incomingRowIdx
+ * @return
+ * @throws SchemaChangeException
+ */
+ @Override
+ public int getBuildHashCodeTreatDataTypes(int incomingRowIdx) throws
SchemaChangeException {
Review comment:
A benefit of this work can be to extract the Hash-Value calculation from the
HashTable class(es). Conceptually the two are independent -- the hash-value is
a parameter given to the hash table API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
