vdiravka commented on a change in pull request #1640: DRILL-7038: Queries on partitioned columns scan the entire datasets URL: https://github.com/apache/drill/pull/1640#discussion_r263491605
########## File path: exec/java-exec/src/test/java/org/apache/drill/TestPartitionColumnScanPruning.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill; + +import org.apache.drill.categories.PlannerTest; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import java.nio.file.Paths; + +@Category({PlannerTest.class}) +public class TestPartitionColumnScanPruning extends PlanTestBase { + + private static final String TABLE_WITH_METADATA = "parquetTable1"; + + @BeforeClass + public static void setUp() { + dirTestWatcher.copyResourceToRoot(Paths.get("multilevel")); + dirTestWatcher.copyResourceToRoot(Paths.get("multilevel/parquet"), Paths.get(TABLE_WITH_METADATA)); + } + + @Test + public void testPartitionColumnScanPruning() throws Exception { + String[] tableNames = {"multilevel/parquet", "multilevel/json", "multilevel/csv"}; + String[] queries = { + "select distinct dir0, dir1 from dfs.`%s`", + "select dir0, dir1 from dfs.`%s` group by 1, 2" + }; + for (String tableName : tableNames) { + for (String query : queries) { + testPlanMatchingPatterns(String.format(query, tableName), new String[]{"Values\\(tuples="}, new String[]{"Scan\\(table="}); + } + } + } + + @Test + public void testPartitionColumnScanPruningWithMetadataCache() throws Exception { + test("refresh table metadata dfs.`%s`", TABLE_WITH_METADATA); + checkForMetadataFile(TABLE_WITH_METADATA); + String query = String.format("select distinct dir0, dir1 from dfs.`%s`", TABLE_WITH_METADATA); + PlanTestBase.testPlanMatchingPatterns(query, new String[]{"Values\\(tuples="}, null); + } + + @Test + public void testPartitionColumnScanPruningIsNotApplied() throws Exception { Review comment: ```suggestion public void testDirScanToValuesConvertingIsNotApplied() throws Exception { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
