arina-ielchiieva commented on a change in pull request #1683: DRILL-6952: Host
compliant text reader on the row set framework
URL: https://github.com/apache/drill/pull/1683#discussion_r264042200
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ColumnExplorer.java
##########
@@ -55,14 +54,30 @@
*/
public ColumnExplorer(OptionManager optionManager, List<SchemaPath> columns)
{
this.partitionDesignator =
optionManager.getString(ExecConstants.FILESYSTEM_PARTITION_COLUMN_LABEL);
- this.columns = columns;
- this.isStarQuery = columns != null && Utilities.isStarQuery(columns);
this.selectedPartitionColumns = Lists.newArrayList();
this.tableColumns = Lists.newArrayList();
this.allImplicitColumns = initImplicitFileColumns(optionManager);
this.selectedImplicitColumns = CaseInsensitiveMap.newHashMap();
+ if (columns == null) {
+ isStarQuery = false;
+ this.columns = null;
+ } else {
+ this.columns = columns;
+ this.isStarQuery = columns != null && Utilities.isStarQuery(columns);
Review comment:
```suggestion
this.isStarQuery = Utilities.isStarQuery(columns);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
