sohami commented on a change in pull request #1650: DRILL-6707: Allow
Merge-Join batch resizing to go smaller than current outgoing row count
URL: https://github.com/apache/drill/pull/1650#discussion_r264462929
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchMemoryManager.java
##########
@@ -24,10 +24,16 @@
import java.util.List;
public class RecordBatchMemoryManager {
- protected static final int MAX_NUM_ROWS = ValueVector.MAX_ROW_COUNT;
+ // The " - 1 " in the number of rows below was chosen to avoid a waste of
(possible) offset vectors memory
+ // where a power-of-2 rows size needlessly doubles the offset vector (see
DRILL-5446)
+ protected static final int MAX_NUM_ROWS = ValueVector.MAX_ROW_COUNT - 1;
Review comment:
This is already taken care in `adjustOutputRowCount`
[here](https://github.com/apache/drill/pull/1650/files#diff-5e65ae81f1488872bf6fe3dfafe00bf0R212)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
