HanumathRao commented on a change in pull request #1691: DRILL-7093 Batch
Sizing in SingleSender
URL: https://github.com/apache/drill/pull/1691#discussion_r267080211
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
##########
@@ -838,4 +838,13 @@ public void dump() {
container, outgoingPosition, Arrays.toString(incomingBatches),
Arrays.toString(batchOffsets),
Arrays.toString(tempBatchHolder), Arrays.toString(inputCounts),
Arrays.toString(outputCounts));
}
+
+ @Override
+ public WritableBatch getWritableBatch(int startIndex, int length) {
+ VectorContainer partialContainer = new
VectorContainer(context.getAllocator(), getSchema());
Review comment:
Looks like getWritableBatch in MergingRecordBatch, SpilledRecordBatch,
AbstractRecordBatch and RecordBatchLoader is same. Is there any way to write a
common function in the hierarchy and use it in all these scenarios?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
