ihuzenko commented on a change in pull request #1692: DRILL-6562: Plugin 
Management improvements
URL: https://github.com/apache/drill/pull/1692#discussion_r267360917
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
 ##########
 @@ -232,6 +209,32 @@ private JsonResult message(String message, Object... 
args) {
     return new JsonResult(String.format(message, args));
   }
 
+  private boolean isSupported(String format) {
+    return JSON_FORMAT.equalsIgnoreCase(format) || 
HOCON_FORMAT.equalsIgnoreCase(format);
+  }
+
+  private List<PluginConfigWrapper> getConfigsFor(String pluginGroup) {
+    return StreamSupport.stream(
+        Spliterators.spliteratorUnknownSize(storage.getStore().getAll(), 
Spliterator.ORDERED), false)
+            .filter(byPluginGroup(pluginGroup))
+            .map(entry -> new PluginConfigWrapper(entry.getKey(), 
entry.getValue()))
+            .sorted(PLUGIN_COMPARATOR)
+            .collect(Collectors.toList());
+  }
+
+  private Predicate<Map.Entry<String, StoragePluginConfig>> 
byPluginGroup(String pluginGroup) {
+    switch (pluginGroup == null ? "" : pluginGroup.toLowerCase()) {
 
 Review comment:
   @vdiravka @aielchiieva  sorry, my fault :) 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to