KazydubB commented on a change in pull request #1712: DRILL-7079: Drill can't
query views from the S3 storage when plain authentication is enabled
URL: https://github.com/apache/drill/pull/1712#discussion_r267943693
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java
##########
@@ -55,6 +56,13 @@ public DotDrillType getType(){
* @return Return owner of the file in underlying file system.
*/
public String getOwner() {
+ if (type == DotDrillType.VIEW && status.getOwner().isEmpty()) {
Review comment:
Owner for views on S3 is always empty.
The `getOwner()` method is currently called for views only and for other
files the method which throws the `IllegalArgumentException` won't be called
with empty `String`. So I suppose we should not throw an `Exception` from the
method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services