bitblender commented on a change in pull request #1702: DRILL-7107 Unable to
connect to Drill 1.15 through ZK
URL: https://github.com/apache/drill/pull/1702#discussion_r268885320
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
##########
@@ -81,23 +78,20 @@
private ConcurrentHashMap<MultiKey, DrillbitEndpoint> endpointsMap = new
ConcurrentHashMap<MultiKey,DrillbitEndpoint>();
private static final Pattern ZK_COMPLEX_STRING =
Pattern.compile("(^.*?)/(.*)/([^/]*)$");
- public ZKClusterCoordinator(DrillConfig config, String connect)
- throws IOException, DrillbitStartupException {
- this(config, connect, null);
+ public ZKClusterCoordinator(DrillConfig config, String connect) {
+ this(config, connect, new DefaultACLProvider());
}
- public ZKClusterCoordinator(DrillConfig config, BootStrapContext context)
- throws IOException, DrillbitStartupException {
- this(config, null, context);
+ public ZKClusterCoordinator(DrillConfig config, ACLProvider aclProvider) {
+ this(config, null, aclProvider);
Review comment:
I tried writing a test where the Drillbits (inside ClusterFixture) are setup
with ZK_APPLY_SECURE_ACL=false (to avoid the need to setup a secure ZK server
within the unit test) and the ClientFixture is setup with
ZK_APPLY_SECURE_ACL=true (to simulate the failure). Starting a test with
different values for the same property turns out to be quite hard because the
ClusterFixture internally instantiates a ClientFixure. Changing this behavior
might affect other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
