arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r269513816
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/BaseScanOperatorExecTest.java ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.scan; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.drill.common.types.TypeProtos.MinorType; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedScanFramework; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedScanFramework.ScanFrameworkBuilder; +import org.apache.drill.exec.physical.impl.scan.ScanTestUtils.ScanFixture; +import org.apache.drill.exec.physical.impl.scan.ScanTestUtils.ScanFixtureBuilder; +import org.apache.drill.exec.physical.impl.scan.framework.BasicScanFactory; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedReader; +import org.apache.drill.exec.physical.impl.scan.framework.SchemaNegotiator; +import org.apache.drill.exec.physical.rowSet.ResultSetLoader; +import org.apache.drill.exec.physical.rowSet.RowSetLoader; +import org.apache.drill.exec.record.BatchSchema; +import org.apache.drill.exec.record.VectorContainer; +import org.apache.drill.exec.record.metadata.SchemaBuilder; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import org.apache.drill.test.SubOperatorTest; +import org.apache.drill.test.rowSet.RowSet.SingleRowSet; +import org.apache.drill.test.rowSet.RowSetUtilities; + +/** + * Test of the scan operator framework. Here the focus is on the + * implementation of the scan operator itself. This operator is + * based on a number of lower-level abstractions, each of which has + * its own unit tests. To make this more concrete: review the scan + * operator code paths. Each path should be exercised by one or more + * of the tests here. If, however, the code path depends on the + * details of another, supporting class, then tests for that class + * appear elsewhere. + */ + +public class BaseScanOperatorExecTest extends SubOperatorTest { + static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(BaseScanOperatorExecTest.class); + + /** + * Base class for the "mock" readers used in this test. The mock readers + * follow the normal (enhanced) reader API, but instead of actually reading + * from a data source, they just generate data with a known schema. + * They also expose internal state such as identifying which methods + * were actually called. + */ + + protected static abstract class BaseMockBatchReader implements ManagedReader<SchemaNegotiator> { + public boolean openCalled; Review comment: Can fields be private / protected? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
