ihuzenko commented on a change in pull request #1706: DRILL-7115: Improve Hive
schema show tables performance
URL: https://github.com/apache/drill/pull/1706#discussion_r271222800
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java
##########
@@ -206,11 +203,11 @@ private Result evaluateHelperFunction(Map<String,
String> recordValues, Function
for(ExprNode arg : exprNode.args) {
Result exprResult = evaluateHelper(recordValues, arg);
- if (exprResult == Result.FALSE) {
- return exprResult;
- }
- if (exprResult == Result.INCONCLUSIVE) {
- result = Result.INCONCLUSIVE;
+ switch (exprResult) {
Review comment:
Suggested change will break the logic, here is a loop and when invocation of
```evaluateHelper(recordValues, arg)``` returned ```Result.INCONCLUSIVE``` once
it's still a chance that next iteration will return false I guess. Previously
here was the chunk:
```java
for(ExprNode arg : exprNode.args) {
Result exprResult = evaluateHelper(recordValues, arg);
if (exprResult == Result.FALSE) {
return exprResult;
}
if (exprResult == Result.INCONCLUSIVE) {
result = Result.INCONCLUSIVE;
}
}
```
I see that my change made it more confusing, so I'll revert it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
