vvysotskyi commented on a change in pull request #1731: DRILL-7153: Drill Fails
to Build using JDK 1.8.0_65
URL: https://github.com/apache/drill/pull/1731#discussion_r271857210
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/FilterEvaluatorUtils.java
##########
@@ -54,9 +54,12 @@
private FilterEvaluatorUtils() {
}
+ @SuppressWarnings("RedundantTypeArguments")
public static RowsMatch evalFilter(LogicalExpression expr,
MetadataBase.ParquetTableMetadataBase footer,
int rowGroupIndex, OptionManager options,
FragmentContext fragmentContext) {
- List<SchemaPath> schemaPathsInExpr = new ArrayList<>(expr.accept(new
FieldReferenceFinder(), null));
+ // Specifies type arguments explicitly to avoid compilation error caused
by JDK-8066974
+ List<SchemaPath> schemaPathsInExpr = new ArrayList<>(
+ expr.<Set<SchemaPath>, Void, RuntimeException>accept(new
FieldReferenceFinder(),null));
Review comment:
Please add space back:
```suggestion
expr.<Set<SchemaPath>, Void, RuntimeException>accept(new
FieldReferenceFinder(), null));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
