paul-rogers commented on a change in pull request #1726: DRILL-7143: Support
default value for empty columns
URL: https://github.com/apache/drill/pull/1726#discussion_r272438198
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/convert/ConvertStringToBoolean.java
##########
@@ -37,7 +37,11 @@ public void setString(final String value) {
baseWriter.setNull();
} else {
try {
- baseWriter.setInt(Boolean.parseBoolean(value) ? 1 : 0);
+ int intValue = Boolean.parseBoolean(value) ? 1 : 0;
Review comment:
Done. Refactored BooleanType a bit so that the lookup is faster for runtime
use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
