dvjyothsna commented on a change in pull request #1723: DRILL-7063: Seperate
metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272822433
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetFilterPushDown.java
##########
@@ -138,18 +138,22 @@ public void testIntPredicateWithEval() throws Exception {
testParquetRowGroupFilterEval(footer, "intCol = 50 or intCol = 160",
RowsMatch.SOME);
//"nonExistCol" does not exist in the table. "AND" with a filter on exist
column
+
testParquetRowGroupFilterEval(footer, "intCol > 100 and nonExistCol =
100", RowsMatch.NONE);
testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol = 100",
RowsMatch.NONE); // since nonExistCol = 100 -> Unknown -> could drop.
testParquetRowGroupFilterEval(footer, "nonExistCol = 100 and intCol > 50",
RowsMatch.NONE); // since nonExistCol = 100 -> Unknown -> could drop.
testParquetRowGroupFilterEval(footer, "intCol > 100 and nonExistCol <
'abc'", RowsMatch.NONE);
testParquetRowGroupFilterEval(footer, "nonExistCol < 'abc' and intCol >
100", RowsMatch.NONE); // nonExistCol < 'abc' hit NumberException and is
ignored, but intCol >100 will
+
// say "drop".
- testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol <
'abc'", RowsMatch.SOME); // because nonExistCol < 'abc' hit NumberException and
+// testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol <
'abc'", RowsMatch.SOME); // because nonExistCol < 'abc' hit NumberException and
Review comment:
Unignored this test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
