amansinha100 commented on a change in pull request #1744: Drill 7148 - Join
order, multi-col ndv and aggregate rowcount fixes for TPCH queries
URL: https://github.com/apache/drill/pull/1744#discussion_r274503913
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdDistinctRowCount.java
##########
@@ -80,10 +87,10 @@ public Double getDistinctRowCount(Join rel,
RelMetadataQuery mq,
@Override
public Double getDistinctRowCount(RelNode rel, RelMetadataQuery mq,
ImmutableBitSet groupKey, RexNode predicate) {
- if (rel instanceof DrillScanRelBase) { // Applies to both
Drill Logical and Physical Rels
+ if (rel instanceof TableScan) { // Applies to both
Drill Logical and Physical Rels
Review comment:
Comment should indicate that it applies to Calcite logical table scan also
since that seems to be the purpose of this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
