amansinha100 commented on a change in pull request #1748: DRILL-7171: Create 
metadata directories cache file in the leaf level directories to support 
ConvertCountToDirectScan optimization.
URL: https://github.com/apache/drill/pull/1748#discussion_r275170762
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/planner/logical/TestConvertCountToDirectScan.java
 ##########
 @@ -274,4 +274,39 @@ public void testCountsWithWildCard() throws Exception {
       test("drop table if exists %s", tableName);
     }
   }
+
+  @Test
+  public void testCountsForLeafDirectories() throws Exception {
 
 Review comment:
   This test is good.   Were you planning to add one with mix of files and 
directories since that's a new behavior this PR is adding. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to