The problem with leaving master branch open for commits while RC is prepared is that commits that won’t be cherry-picked into 1.16, will be still committed into 1.16 SNAPSHOT, since usually master is updated to 1.17 SNAPSHOT only after the release. But in reality they belong to 1.17 version. That’s why I though we actually closed master for commits for the period of the release before.
Kind regards, Arina > On Apr 11, 2019, at 3:20 AM, Sorabh Hamirwasia <sohami.apa...@gmail.com> > wrote: > > Hi All, > I have created 1.16.0 branch with commit to revert protobuf change. There > is only 1 blocker right now which Abhsihek shared. Meanwhile we will be > running regression tests and performance tests to see if there are any > other issues before creating RC0. All the commits for blocking issues will > be cherry-picked to this 1.16.0 branch so master branch is still open for > commits. > > Blocker: DRILL-7166: Tests doing count(* ) with wildcards in table name are > querying metadata cache and returning wrong results > <https://issues.apache.org/jira/browse/DRILL-7166> > 1.16.0 Branch - https://github.com/apache/drill/commits/1.16.0 > > Thanks, > Sorabh > > On Wed, Apr 10, 2019 at 5:15 PM Abhishek Girish <agir...@apache.org> wrote: > >> FYI - DRILL-7166 <https://issues.apache.org/jira/browse/DRILL-7166> is a >> blocker for the release and is being actively worked on by Jyothsna. >> >> On Mon, Apr 8, 2019 at 3:59 PM Sorabh Hamirwasia <sohami.apa...@gmail.com> >> wrote: >> >>> Hi All, >>> I will create 1.16.0 branch later today and will merge in all >>> ready-to-commit JIRA's. Please try to close most of the PR's by EOD today >>> (around 5:30 P.M. PST). Once the branch is created I will work on >> reverting >>> the protobuf changes on 1.16.0 branch. >>> >>> There are few other JIRA's which are in review and almost ready. >> Tomorrow, >>> whichever PR is categorized as blocker or must-have for release will only >>> be cherry-picked. >>> >>> Thanks, >>> Sorabh >>> >>> On Thu, Apr 4, 2019 at 4:29 PM Sorabh Hamirwasia < >> sohami.apa...@gmail.com> >>> wrote: >>> >>>> Hi All, >>>> A gentle reminder about the release cut-off date of *Apr 8, 2019.* >>>> >>>> - Currently there are *12 JIRA's [1] in Reviewable state* and I am >>>> seeing progress being made on these PR's. Please try to resolve all >>> the >>>> review comments for your PR by Monday. >>>> - Also currently there are *10 JIRA's which are in Open and In >>>> Progress [2]* state, given there are only few days left until >> cut-off >>>> date please either move these JIRA's to 1.17 or try to make it to >>>> ready-to-commit (code review complete and approved) state by Monday >>> EOD. >>>> >>>> [1]: >>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20status%20%3D%20Reviewable%20AND%20(labels%20!%3D%20ready-to-commit%20OR%20labels%20is%20EMPTY)%20ORDER%20BY%20assignee%20ASC >>>> [2]: >>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20(status%20%3D%20Open%20OR%20status%20%3D%20%22In%20Progress%22)%20ORDER%20BY%20status%20DESC >>>> >>>> Thanks, >>>> Sorabh >>>> >>>> On Mon, Mar 25, 2019 at 9:37 AM Sorabh Hamirwasia < >>> sohami.apa...@gmail.com> >>>> wrote: >>>> >>>>> Hi Aman >>>>> Thanks for the information. >>>>> >>>>> Given we need 2 weeks of estimated dev effort for parquet metadata >>>>> caching and other open items have also estimated similar remaining >>> effort, >>>>> I would like to propose first release cut-off date as *Apr 8, 2019.* >>> Please >>>>> try to include all the major feature work by then. Let's try to close >>> all >>>>> the open and in progress items [1] >>>>> >>>>> [1]: >>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20(status%20%3D%20Open%20OR%20status%20%3D%20%22In%20Progress%22)%20ORDER%20BY%20status%20DESC%2C%20assignee%20ASC >>>>> >>>>> Thanks, >>>>> Sorabh >>>>> >>>>> On Fri, Mar 22, 2019 at 1:48 PM Aman Sinha <amansi...@gmail.com> >> wrote: >>>>> >>>>>> Hi Sorabh, >>>>>> for the Parquet Metadata caching improvements, we are estimating 2 >> more >>>>>> weeks for the feature development. >>>>>> This does not include bug fixing if any blocker bugs are discovered >>>>>> during >>>>>> functional testing. >>>>>> Hope that helps with setting the release cut-off date. >>>>>> >>>>>> Aman >>>>>> >>>>>> >>>>>> On Tue, Mar 19, 2019 at 5:23 PM Sorabh Hamirwasia < >>>>>> sohami.apa...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Hi All, >>>>>>> Thanks for your response. We discussed about release today in >>> hangout. >>>>>> Most >>>>>>> of the JIRA's shared in this thread will be considered for 1.16 >> since >>>>>> they >>>>>>> need at most a week or two to wrap up. >>>>>>> >>>>>>> - DRILL-6540 is to support Hadoop 3.1 compatibility which >>> provides a >>>>>>> risk at this point of the release. It is moved out to 1.17 so >> that >>>>>> we >>>>>>> will >>>>>>> have enough runtime with new set of libraries. >>>>>>> - DRILL-6642 upgraded the protobuf version from 2.5.0 to 3.6.1. >>> This >>>>>>> includes dependencies on C++ 11 and requires new ODBC driver to >> be >>>>>>> built. >>>>>>> Getting new driver with new protobuf may take around 2 months or >>> so >>>>>> as >>>>>>> Simba has to upgrade their environment. The general agreement in >>>>>>> community >>>>>>> was to revert the protobuf update on 1.16.0 branch only so that >> we >>>>>> can >>>>>>> release new ODBC driver quickly. While master will still have >> the >>>>>>> original >>>>>>> commit so that by 1.17 release timeline we will have a new >> driver >>>>>> with >>>>>>> updated protobuf. >>>>>>> - Currently there are 23 Open and InProgress issues with 5 >> blocker >>>>>> bugs >>>>>>> < >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20(status%20%3D%20%22In%20Progress%22%20OR%20status%20%3D%20Open)%20ORDER%20BY%20status%20DESC%2C%20assignee%20ASC >>>>>>>> . >>>>>>> Please work on these and try to wrap up ASAP. >>>>>>> - Apart from above there are 14 issues under Review >>>>>>> < >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20status%20%3D%20Reviewable%20ORDER%20BY%20assignee%20ASC >>>>>>>> . >>>>>>> Please ping the reviewers to help review your PR so that it can >> be >>>>>>> merged >>>>>>> ASAP >>>>>>> >>>>>>> We are currently looking for first cut-off date at end of first >> week >>> of >>>>>>> April. Few folks are working on Parquet Metadata caching >> improvement >>>>>> and >>>>>>> will need couple of days to estimate remaining work. Once that is >>> done >>>>>> we >>>>>>> will finalize the cut-off date. >>>>>>> >>>>>>> Thanks, >>>>>>> Sorabh >>>>>>> >>>>>>> On Tue, Mar 19, 2019 at 5:24 AM Bohdan Kazydub < >>>>>> bohdan.kazy...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hello Sorabh, >>>>>>>> >>>>>>>> I'm currently working on a small bug when querying views from S3 >>>>>> storage >>>>>>>> with plain authentication [DRILL-7079]. >>>>>>>> I'd like to include it into Drill 1.16. I'll need 1-2 days for >>>>>> making the >>>>>>>> PR as well. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Bohdan >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Mar 19, 2019 at 1:55 PM Igor Guzenko < >>>>>> ihor.huzenko....@gmail.com >>>>>>>> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hello Sorabh, >>>>>>>>> >>>>>>>>> I'm currently working on small improvement for Hive schema show >>>>>> tables >>>>>>>>> [DRILL-7115]. >>>>>>>>> I'd like to include it into Drill 1.16. I'll need 1-2 days for >>>>>> making >>>>>>> the >>>>>>>>> PR. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Igor >>>>>>>>> >>>>>>>>> On Mon, Mar 18, 2019 at 11:25 PM Kunal Khatua < >> ku...@apache.org> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Khurram >>>>>>>>>> >>>>>>>>>> Currently, for DRILL-7061, the feature has been disabled. If >>> I'm >>>>>> able >>>>>>>> to >>>>>>>>> get a commit within the week for DRILL-6960, this will be >>>>>> addressed in >>>>>>>> that. >>>>>>>>>> >>>>>>>>>> DRILL-7110 is something that is required as well, to allow >>>>>> DRILL-6960 >>>>>>>> to >>>>>>>>> be accepted. >>>>>>>>>> >>>>>>>>>> ~ Kunal >>>>>>>>>> On 3/18/2019 1:20:16 PM, Khurram Faraaz <kfar...@mapr.com> >>>>>> wrote: >>>>>>>>>> Can we also have the fix fox DRILL-7061 >>>>>>>>>> in Drill 1.16 ? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Khurram >>>>>>>>>> >>>>>>>>>> On Mon, Mar 18, 2019 at 11:40 AM Karthikeyan Manivannan >>>>>>>>>> kmanivan...@mapr.com> wrote: >>>>>>>>>> >>>>>>>>>>> Please include DRILL-7107 >>>>>>>>>>> https://issues.apache.org/jira/browse/DRILL-7107> >>>>>>>>>>> I will open the PR today. >>>>>>>>>>> It is a small change and fixes a basic usability issue. >>>>>>>>>>> >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> Karthik >>>>>>>>>>> >>>>>>>>>>> On Thu, Mar 14, 2019 at 4:50 PM Charles Givre wrote: >>>>>>>>>>> >>>>>>>>>>>> One more… DRILL-7014 is basically done and I’d like to >> see >>>>>> that >>>>>>> get >>>>>>>>> into >>>>>>>>>>>> Drill 1.16. >>>>>>>>>>>> >>>>>>>>>>>>> On Mar 14, 2019, at 19:44, Charles Givre wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Who should I add as a reviewer for 7032? >>>>>>>>>>>>> >>>>>>>>>>>>>> On Mar 14, 2019, at 19:42, Sorabh Hamirwasia >>>>>>>>>>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Charles, >>>>>>>>>>>>>> Can you please add reviewer for DRILL-7032 ? >>>>>>>>>>>>>> For DRILL-6970 the PR is closed by the author, I have >>>>>> pinged >>>>>>> in >>>>>>>>> JIRA >>>>>>>>>>>> asking >>>>>>>>>>>>>> to re-open so that it can be reviewed. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Sorabh >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Mar 14, 2019 at 4:29 PM Charles Givre >>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Sorabh, >>>>>>>>>>>>>>> I have 3 PRs that are almost done, awaiting final >>> review. >>>>>>>>>>> Drill-7077, >>>>>>>>>>>>>>> DRILL-7032, DRILL-7021. I owe @ariina some fixes for >>>>>> 7077, >>>>>>> but >>>>>>>>> I’m >>>>>>>>>>>> waiting >>>>>>>>>>>>>>> for review of the others. Also, there is that >>> DRILL-6970 >>>>>>> about >>>>>>>>> the >>>>>>>>>>>> buffer >>>>>>>>>>>>>>> overflows in the logRegex reader that isn’t mine but >>> I’d >>>>>> like >>>>>>>> to >>>>>>>>> see >>>>>>>>>>>>>>> included. >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> —C >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mar 14, 2019, at 13:13, Sorabh Hamirwasia >>>>>>>>>>> sohami.apa...@gmail.com >>>>>>>>>>>>> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Arina, >>>>>>>>>>>>>>>> Thanks for your response. With ETA of two weeks we >> are >>>>>>> looking >>>>>>>>> at >>>>>>>>>>> end >>>>>>>>>>>> of >>>>>>>>>>>>>>>> the month or beginning next month. I will wait until >>>>>> Monday >>>>>>>> for >>>>>>>>>>>> others to >>>>>>>>>>>>>>>> respond and then will finalize on a cut-off date. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Sorabh >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Mar 13, 2019 at 4:28 AM Arina Ielchiieva >>>>>>>>>>>>>>> arina.yelchiy...@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi Sorabh, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> thanks for volunteering to do the release. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Paul and I are working on file schema provisioning >>> for >>>>>> text >>>>>>>>> file >>>>>>>>>>>> storage >>>>>>>>>>>>>>>>> which is aimed for 1.16. To wrap up the work we >> need >>> to >>>>>>>>> deliver two >>>>>>>>>>>>>>> Jiras: >>>>>>>>>>>>>>>>> DRILL-7095 and DRILL-7011. ETA: 2 weeks. >>>>>>>>>>>>>>>>> Please plan the release date accordingly. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Kind regards, >>>>>>>>>>>>>>>>> Arina >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Tue, Mar 12, 2019 at 9:16 PM Sorabh Hamirwasia >>>>>>>>>>>>>>> sohami.apa...@gmail.com >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi All, >>>>>>>>>>>>>>>>>> It's around two and a half month since we did >> 1.15.0 >>>>>>> release >>>>>>>>> for >>>>>>>>>>>> Apache >>>>>>>>>>>>>>>>>> Drill. Based on our 3 months release cadence I >> think >>>>>> it's >>>>>>>>> time to >>>>>>>>>>>>>>> discuss >>>>>>>>>>>>>>>>>> our next release. I will volunteer to manage the >>> next >>>>>>>> release. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> **Below is the current JIRA stats:* >>>>>>>>>>>>>>>>>> *[1] Open#: 15* >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> - Would be great if everyone can look into their >>>>>> assigned >>>>>>>>> tickets >>>>>>>>>>>> and >>>>>>>>>>>>>>>>>> update the fix version as needed. Please keep the >>> ones >>>>>>> which >>>>>>>>> you >>>>>>>>>>>> find >>>>>>>>>>>>>>>>>> must >>>>>>>>>>>>>>>>>> have and can be completed sooner. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> *[2] InProgress#: 11* >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> - If you think we *must* include any issues from >>> this >>>>>> list >>>>>>>>> then >>>>>>>>>>>>>>> please >>>>>>>>>>>>>>>>>> reply on this thread. Also would be great to know >>> how >>>>>> much >>>>>>>>> time >>>>>>>>>>> you >>>>>>>>>>>>>>>>>> think >>>>>>>>>>>>>>>>>> is needed for these issues. Based on that we can >>> take >>>>>> a >>>>>>> call >>>>>>>>> which >>>>>>>>>>>>>>> one >>>>>>>>>>>>>>>>>> to >>>>>>>>>>>>>>>>>> target for this release. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> *[3] Reviewable#: 14* >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> - All the reviewers and authors should try to >> close >>>>>> these >>>>>>> as >>>>>>>>> soon >>>>>>>>>>> as >>>>>>>>>>>>>>>>>> possible. If you think that any of the PR needs >>>>>> rework or >>>>>>>>> should >>>>>>>>>>> be >>>>>>>>>>>>>>>>>> postponed to next release then please update the >>>>>> status >>>>>>> and >>>>>>>>> fix >>>>>>>>>>>>>>>>> version >>>>>>>>>>>>>>>>>> for >>>>>>>>>>>>>>>>>> those JIRA's as well. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> After above JIRA's are reviewed by everyone and >>> based >>>>>> on >>>>>>>> their >>>>>>>>>>>> inputs >>>>>>>>>>>>>>> we >>>>>>>>>>>>>>>>>> can define a cut off date. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> *Approximate numbers as it can change based on >> JIRA >>>>>>> updates. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Sorabh >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> [1]: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20issuetype%20in%20(standardIssueTypes()%2C%20subTaskIssueTypes())%20AND%20fixVersion%20%3D%201.16.0%20AND%20status%20%3D%20Open%20ORDER%20BY%20assignee%20ASC >>>>>>>>>>>>>>>>>> [2]: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20status%20in%20(%22In%20Progress%22)%20AND%20fixVersion%20%3D%201.16.0%20ORDER%20BY%20assignee%20ASC >>>>>>>>>>>>>>>>>> [3]: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20DRILL%20AND%20status%20in%20(Reviewable)%20AND%20fixVersion%20%3D%201.16.0%20AND%20(labels%20!%3D%20ready-to-commit%20OR%20labels%20is%20EMPTY)%20ORDER%20BY%20assignee%20ASC >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>> >>
