cgivre commented on a change in pull request #1756: Drill-7185: Drill Fails to
Read Large Packets
URL: https://github.com/apache/drill/pull/1756#discussion_r276868473
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
##########
@@ -408,7 +408,7 @@ private void decodePcapHeader(final byte[] header, final
boolean byteOrder, fina
timestamp = timestampMicro / 1000L;
originalLength = getIntFileOrder(byteOrder, header, offset +
PacketConstants.ORIGINAL_LENGTH_OFFSET);
packetLength = getIntFileOrder(byteOrder, header, offset +
PacketConstants.ACTUAL_LENGTH_OFFSET);
- Preconditions.checkState(originalLength < maxLength,
+ Preconditions.checkState(originalLength <= maxLength,
Review comment:
I'm honestly not sure, but I had a bunch of pcap from our honeypot that had
a length of 96 and they crashed Drill. In those instances, `maxLength` was set
to 96.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
