Arina/Anton thanks for catching DRILL-7186 Sorabh, agree with you DRILL-7190 should be resolved and included to 1.16.0 Drill release. I will provide PR shortly.
Kind regards Vitalii On Fri, Apr 19, 2019 at 8:05 PM SorabhApache <[email protected]> wrote: > Hi Anton/Arina, > Thanks for finding the issue and fixing it. I have some follow-up questions > for the original change which I have posted in DRILL-7186 > <https://issues.apache.org/jira/browse/DRILL-7186>, would be great to > clarify on those as well. > > Thanks, > Sorabh > > On Fri, Apr 19, 2019 at 9:54 AM Arina Yelchiyeva < > [email protected]> > wrote: > > > Fix is ready: https://github.com/apache/drill/pull/1757 > > > > > On Apr 19, 2019, at 2:36 PM, Anton Gozhiy <[email protected]> wrote: > > > > > > Reported a regression: > > > https://issues.apache.org/jira/browse/DRILL-7186 > > > > > > On Fri, Apr 19, 2019 at 2:10 AM Bob Rudis <[email protected]> wrote: > > > > > >> Thx Sorabh! > > >> > > >> On Thu, Apr 18, 2019 at 16:23 SorabhApache <[email protected]> wrote: > > >> > > >>> Hi Bob, > > >>> With protobuf change both JDBC and ODBC will need to be updated but > for > > >>> 1.16 release this change was reverted since it will take some time to > > >>> prepare for drivers with latest protobuf versions. In the original > JIRA > > >>> there is a comment stating that the commit is reverted on 1.16 branch > > and > > >>> will add the commit id once the release branch is finalized. > > >>> > > >>> JIRA: https://issues.apache.org/jira/browse/DRILL-6642 > > >>> Commit that revert's the change [1]: > > >>> 6eedd93dadf6d7d4f745f99d30aee329976c2191 > > >>> > > >>> [1]: https://github.com/sohami/drill/commits/drill-1.16.0 > > >>> > > >>> Thanks, > > >>> Sorabh > > >>> > > >>> On Thu, Apr 18, 2019 at 1:12 PM Bob Rudis <[email protected]> wrote: > > >>> > > >>>> Q abt the RC (and eventual full release): Does > > >>>> https://issues.apache.org/jira/browse/DRILL-5509 mean that the ODBC > > >>>> drivers will need to be updated to avoid warning messages (and > > >>>> potential result set errors) as the was the case with a previous > > >>>> release or is this purely (as I read the ticket) a "make maven less > > >>>> unhappy" and no underlying formats are changing? If it does mean the > > >>>> ODBC drivers need changing, any chance there's a way to ensure the > > >>>> provider of those syncs it closer to release than the last time? > > >>>> > > >>>> On Thu, Apr 18, 2019 at 3:06 PM SorabhApache <[email protected]> > > >> wrote: > > >>>>> > > >>>>> Hi Drillers, > > >>>>> I'd like to propose the first release candidate (RC0) for the > Apache > > >>>> Drill, > > >>>>> version 1.16.0. > > >>>>> > > >>>>> The RC0 includes total of 211 resolved JIRAs [1]. > > >>>>> Thanks to everyone for their hard work to contribute to this > release. > > >>>>> > > >>>>> The tarball artifacts are hosted at [2] and the maven artifacts are > > >>>> hosted > > >>>>> at [3]. > > >>>>> > > >>>>> This release candidate is based on commit > > >>>>> 61cd2b779d85ff1e06947327fca2e076994796b5 located at [4]. > > >>>>> > > >>>>> Please download and try out the release. > > >>>>> > > >>>>> The vote ends at 07:00 PM UTC (12:00 PM PDT, 10:00 PM EET, 12:30 AM > > >>>>> IST(next day)), Apr 23rd, 2019 > > >>>>> > > >>>>> [ ] +1 > > >>>>> [ ] +0 > > >>>>> [ ] -1 > > >>>>> > > >>>>> Here is my vote: +1 > > >>>>> > > >>>>> [1] > > >>>>> > > >>>> > > >>> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344284 > > >>>>> [2] http://home.apache.org/~sorabh/drill/releases/1.16.0/rc0/ > > >>>>> [3] > > >>>>> > > >>> > > https://repository.apache.org/content/repositories/orgapachedrill-1066/ > > >>>>> [4] https://github.com/sohami/drill/commits/drill-1.16.0 > > >>>>> > > >>>>> Thanks, > > >>>>> Sorabh > > >>>> > > >>> > > >> > > > > > > > > > -- > > > Sincerely, Anton Gozhiy > > > [email protected] > > > > >
