vvysotskyi commented on a change in pull request #1754: DRILL-7098: File
Metadata Metastore Plugin
URL: https://github.com/apache/drill/pull/1754#discussion_r277232508
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScanWithMetadata.java
##########
@@ -151,13 +152,13 @@ public long getColumnValueCount(SchemaPath column) {
long colNulls;
if (columnStats != null) {
Long nulls = (Long)
columnStats.getStatistic(ColumnStatisticsKind.NULLS_COUNT);
- colNulls = nulls != null ? nulls : GroupScan.NO_COLUMN_STATS;
+ colNulls = nulls != null ? nulls : Statistic.NO_COLUMN_STATS;
} else {
return 0;
}
- return GroupScan.NO_COLUMN_STATS == tableRowCount
- || GroupScan.NO_COLUMN_STATS == colNulls
- ? GroupScan.NO_COLUMN_STATS : tableRowCount - colNulls;
+ return Statistic.NO_COLUMN_STATS == tableRowCount
Review comment:
And here
```suggestion
return Statistic.NO_COLUMN_STATS == tableRowCount
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
