gparai commented on a change in pull request #1772: DRILL-7187: Improve
selectivity estimation of BETWEEN predicates and …
URL: https://github.com/apache/drill/pull/1772#discussion_r279571290
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdSelectivity.java
##########
@@ -356,8 +426,8 @@ private boolean isMultiColumnPredicate(final RexNode node)
{
return findAllRexInputRefs(node).size() > 1;
}
- private static List<RexInputRef> findAllRexInputRefs(final RexNode node) {
- List<RexInputRef> rexRefs = new ArrayList<>();
+ private static Set<RexInputRef> findAllRexInputRefs(final RexNode node) {
Review comment:
Would this not break the existing logic? For a predicate like $0=$0 using
the `Set` would cause the `isMultiColumnPredicate` function to return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
