dvjyothsna commented on a change in pull request #1771: DRILL-7199: Optimize population of metadata for non-interesting columns URL: https://github.com/apache/drill/pull/1771#discussion_r280180725
########## File path: exec/java-exec/src/main/java/org/apache/drill/metastore/NonInterestingColumnsMetadata.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.metastore; + +import org.apache.drill.common.expression.SchemaPath; +import org.apache.drill.exec.record.metadata.ColumnMetadata; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import java.util.Map; + +/** + * Represents a metadata for the non-interesting columns. Since the refresh command doesn't store the non-interesting + * columns stats in teh cache file, there is a need to mark column statistics of non-interesting as unknown to + * differentiate the non-interesting columns from non-existent columns. + */ +public class NonInterestingColumnsMetadata implements BaseMetadata { Review comment: Added a comment to clarify that NonInterestingColumnsMetadata is not applicable to some of the methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
