vvysotskyi commented on a change in pull request #1777: DRILL-6965: Implement schema table function parameter URL: https://github.com/apache/drill/pull/1777#discussion_r280561180
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/table/function/TableSignature.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.table.function; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * Describes table and parameters that can be used during table initialization and usage. + * Common parameters are those that are common for all tables (ex: schema). + * Specific parameters are those that are specific to the schema table belongs to. + */ +public final class TableSignature { + + private final String name; + private final List<TableParamDef> commonParams; + private final List<TableParamDef> specificParams; + private final List<TableParamDef> params; + + public static TableSignature of(String name) { + return new TableSignature(name, Collections.emptyList(), Collections.emptyList()); + } + + public static TableSignature of(String name, List<TableParamDef> primaryParams) { Review comment: Could you please rename arguments here and in the method below? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
