amansinha100 commented on a change in pull request #1783: DRILL-7240: Catch
runtime pruning filter-match exceptions and do not prune these rowgroups
URL: https://github.com/apache/drill/pull/1783#discussion_r281442046
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
##########
@@ -214,10 +225,14 @@ protected ScanBatch getBatch(ExecutorFragmentContext
context, AbstractParquetRow
mapWithMaxColumns = createReaderAndImplicitColumns(context,
rowGroupScan, oContext, columnExplorer, readers, implicitColumns,
mapWithMaxColumns, firstRowGroup, fs,
firstFooter, true);
}
+ // do some logging, if relevant
if ( totalPruneTime > 0 ) {
logger.info("Finished parquet_runtime_pruning in {} usec. Out of given
{} rowgroups, {} were pruned. {}", totalPruneTime, totalRowgroups,
rowgroupsPruned,
totalRowgroups == rowgroupsPruned ? "ALL_PRUNED !!" : "");
}
+ if ( countMatchClassCastExceptions > 0 ) {
+ logger.info("Run-time pruning check skipped for {} out of {} rowgroups
due to: {}",countMatchClassCastExceptions, totalRowgroups,
matchCastErrorMessage);
Review comment:
Minor point: The word 'check' should be removed since at least a partial
check was performed and the failure happened during that process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
