arina-ielchiieva commented on a change in pull request #1789: DRILL-7181:
Improve V3 text reader (row set) error messages
URL: https://github.com/apache/drill/pull/1789#discussion_r285021267
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileScanFramework.java
##########
@@ -206,7 +206,13 @@ protected FileSplit nextSplit() {
@Override
protected SchemaNegotiatorImpl newNegotiator() {
- return new FileSchemaNegotiatorImpl(this);
+ SchemaNegotiatorImpl nego = new FileSchemaNegotiatorImpl(this);
+ String tableName =
Path.getPathWithoutSchemeAndAuthority(currentSplit.getPath()).toString();
+ if (currentSplit.getStart() != 0) {
+ tableName += String.format(", offset %,d", currentSplit.getStart());
+ }
+ nego.setTableName(tableName);
Review comment:
Not quite sure what table name this will be, why you need offset etc. Can
you please give an example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services