arina-ielchiieva commented on a change in pull request #1788: DRILL-7204: Add
proper validation when creating plugin
URL: https://github.com/apache/drill/pull/1788#discussion_r285189347
##########
File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
##########
@@ -126,9 +128,9 @@
}
function deleteFunction() {
- if (confirm("Are you sure?")) {
- $.get("/storage/${model.getName()}/delete", serverMessage);
- }
+ showConfirmationDialog("Are you sure?", function() {
Review comment:
Maybe we should improve message, something like: `Are you sure you want to
delete ....?`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
