Hi Vitalii, Regarding the first point, mvnrepository shows only usages for projects which also deployed to the central repository, but it is possible that there may be projects which use drill-root and weren't deployed there.
I don't know about such usages, but my opinion was if we can avoid making inconvenience for other projects, then we should do it. Kind regards, Volodymyr Vysotskyi On Thu, Jun 6, 2019 at 7:41 AM Vitalii Diravka <[email protected]> wrote: > Hi Vova! > > 1. Not a lot usages of *org.apache.drill:drill-root:1.16.0 :)* > https://mvnrepository.com/artifact/org.apache.drill/drill-root > Other projects usually uses drill modules directly: *drill-exec* or > *drill-common* > > *2. artifactId* – a unique name of the project and it helps identify the > project. And requirements for it in Maven. > From Maven documentation <https://maven.apache.org/pom.html#The_Basics>: > artifactId: The artifactId is generally the name that the project is known > by. Although the groupId is important, people within the group will rarely > mention the groupId in discussion ... It, along with the groupId, create a > key that separates this project from every other project in the world (at > least, it should :) ). Along with the groupId, the artifactId fully defines > the artifact's living quarters within the repository. > > For me new naming is better and more useful, but it is also fine to leave > it as is. If there are no other ideas, please feel free to close the PR and > provide suggested changes. > > > Kind regards > Vitalii > > > On Mon, Jun 3, 2019 at 12:05 PM Vova Vysotskyi <[email protected]> wrote: > > > Hi all, > > > > There are not so many benefits for this change, but it will force > > underlying projects which use 'drill-root' artifactId to make more > changes > > after updating to the renamed version (or even miss newer versions > because > > they will be looking for 'drill-root' artifactId). > > > > Considering the fact that there are no requirements from the Apache side > on > > the naming, and some other projects also have similar naming, I think it > > would be better to leave the artifactId as it is. > > > > But as pointed above, it would be good to replace the usage of > > 'apache-drill' with the variable. > > > > So here is my -0 for this change. > > > > Kind regards, > > Volodymyr Vysotskyi > > > > > > On Thu, May 9, 2019 at 12:51 AM Vitalii Diravka <[email protected]> > > wrote: > > > > > Kunal, > > > There is no need to re-setup Drill IDE project, the only one artifact > > name > > > is changed and it will be introduced in maven central too. > > > Regarding DRILL-6956 it requires update of Maven version to 3.5.0 for > > > developers, DevOps and users. However I think we should proceed with > this > > > task too. > > > > > > Abhishek, > > > We have several ways here: > > > 1. The approach suggested by me in PR [1]. I follow this way, because > it > > is > > > suggestion by Apache Maven [2]: > > > > > > > > A typical artifact produced by Maven would have the form > > > > <artifactId>-<version>.<extension> (for example, myapp-1.0.jar). > > > > > > 2. <artifactId>drill</artifactId> and add the new property <prefix> > > > apache-drill</prefix>, then to use it everywhere instead of > > > ${project.artifactId} and ${project.parent.artifactId}. > > > 3. <artifactId>drill</artifactId> and change the name of all artifacts > > > (jar, tar archives etc.), for example: drill-1.16.0-SNAPSHOT.tar.gz > > > 4. Do not change *artifactId* name :) > > > > > > [1] https://github.com/apache/drill/pull/1746 > > > [2] https://maven.apache.org/guides/getting-started/ > > > > > > Kind regards > > > Vitalii > > > > > > > > > On Mon, Apr 22, 2019 at 8:53 PM Abhishek Girish <[email protected]> > > > wrote: > > > > > > > Also, looking at the apache project examples you shared (like 'hive' > & > > > > 'hbase'), 'drill' might be a better choice, in my opinion, to keep it > > > > consistent. I don't understand how that would impact the distribution > > > > tarball file name. If it helps, we could have a full name variable in > > the > > > > main pom.xml for such reasons? > > > > > > > > On Mon, Apr 22, 2019 at 10:19 AM Kunal Khatua <[email protected]> > > wrote: > > > > > > > > > Hi Vitalii > > > > > > > > > > I think this would be a temporary headache for people to > > > re-setup/update > > > > > their IDEs' projects. > > > > > > > > > > Is it possible to have this done together with > > > > > https://issues.apache.org/jira/browse/DRILL-6956 [ > > > > > https://issues.apache.org/jira/browse/DRILL-6956] (Maintain a > single > > > > > entry for Drill Version in the pom file) ? > > > > > > > > > > ~ Kunal > > > > > On 4/22/2019 4:13:27 AM, Vitalii Diravka <[email protected]> > wrote: > > > > > Hi all! > > > > > > > > > > I am going to rename project.artifactId (see [1] or DRILL-7169) > from > > ' > > > > > *drill-root*' [2] to '*apache-drill*' or 'drill'. > > > > > Some other project examples: > > > > > Hbase: hbase [3] > > > > > Calcite: calcite [4] Parquet: parquet > > > > > artifactId> [5] > > > > > Hive: hive [6] Avro: avro-toplevel > > > > > artifactId> [7] Spark: spark-parent_2.12 [8] > > > > > > > > > > Renaming to 'apache-drill' artifatId will allow to use this > variable > > > in a > > > > > lot of places to avoid hard-coding '*apache-drill*' string in > > different > > > > > paths [1]. A typical artifact produced by Maven would have the form > > > > > -. (for example, myapp-1.0.jar) [9], > > > > > [10]. Current > > > > > Drill final name of different artifacts: > > > > > apache-drill-${project.version} > > > > > Therefore looks like '*apache-drill*' is the best name of Drill > > > > artifactId, > > > > > which will allow to keep consistency of all Drill artifacts. > > > > > > > > > > For sure it will lead for changing of Drill artifactId in maven > > central > > > > > repository: > > > > > https://mvnrepository.com/artifact/org.apache.drill/drill-root > > > > > What do you think guys? Can we update it? Are there any risks to do > > it? > > > > > > > > > > > > > > > [1] https://github.com/apache/drill/pull/1746 > > > > > [2] https://github.com/apache/drill/blob/master/pom.xml#L32 > > > > > > > > > > [3] https://github.com/apache/hbase/blob/master/pom.xml#L40 > > > > > [4] https://github.com/apache/calcite/blob/master/pom.xml#L28 > > > > > [5] https://github.com/apache/parquet-mr/blob/master/pom.xml#L11 > > > > > [6] https://github.com/apache/hive/blob/master/pom.xml#L23 > > > > > [7] https://github.com/apache/avro/blob/master/pom.xml#L29 > > > > > [8] https://github.com/apache/spark/blob/master/pom.xml#L28 > > > > > [9] > > https://maven.apache.org/guides/mini/guide-naming-conventions.html > > > > > [10] https://maven.apache.org/guides/getting-started/ > > > > > > > > > > Kind regards > > > > > Vitalii > > > > > > > > > > > > > > >
