paul-rogers commented on a change in pull request #1807: DRILL-7293: Convert 
the regex ("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r294614546
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md
 ##########
 @@ -143,6 +143,14 @@ cardinality.
 You may find it helpful to specify the regex and column names via the plugin
 config, types via the `CREATE SCHEMA` command.
 
+## Table Functions
+
+Log files come in many forms. It would be very convenient to use Drill table
 
 Review comment:
   As I recall, Drill does not have a good way to deal with changes to the 
schema of a storage plugin. Some time back, I remember struggling to understand 
why my server would not start, only to eventually learn that some plugin or 
other changed its config and so Drill failed when trying to load the existing 
config from ZK. Has this been fixed?
   
   If we change schema to a string, we'd need to run code to convert old 
configs. Also, we'd have the problem of what to do with the type property. We 
could not easily convert an existing config into a table schema.
   
   Given these uncertainties, my thought was to leave the config alone and try 
to fit in the provided schema as best we can on top of the existing config.
   
   Can you think of a better approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to