arina-ielchiieva commented on a change in pull request #1807: DRILL-7293:
Convert the regex ("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r294674117
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md
##########
@@ -143,6 +143,14 @@ cardinality.
You may find it helpful to specify the regex and column names via the plugin
config, types via the `CREATE SCHEMA` command.
+## Table Functions
+
+Log files come in many forms. It would be very convenient to use Drill table
Review comment:
I guess initial choice of list property did not take into account that it
does not work with table function. I don't think you can fix this backward
compatibility in ZK but since this plugin is a role model for others I think it
should have proper configuration, so changing `schema` property to be `String`
instead `List` might be reasonable. Or can we have both properties one in
String, another in `List<String>`? We can indicate in release notes that log
plugin has been changed and config in ZK must be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
