ihuzenko commented on a change in pull request #1810: DRILL-7271: Refactor
Metadata interfaces and classes to contain all needed information for the File
based Metastore
URL: https://github.com/apache/drill/pull/1810#discussion_r296189471
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java
##########
@@ -461,14 +465,14 @@ public static ObjectMapper getMapper() {
* @param statsProvider the source of statistics
* @return map of {@link StatisticsKind} and statistics values
*/
- public static Map<StatisticsKind, Object>
getEstimatedTableStats(DrillStatsTable statsProvider) {
+ public static List<StatisticsHolder> getEstimatedTableStats(DrillStatsTable
statsProvider) {
if (statsProvider != null && statsProvider.isMaterialized()) {
- Map<StatisticsKind, Object> tableStatistics = new HashMap<>();
- tableStatistics.put(TableStatisticsKind.EST_ROW_COUNT,
statsProvider.getRowCount());
- tableStatistics.put(TableStatisticsKind.HAS_STATISTICS, Boolean.TRUE);
+ List<StatisticsHolder> tableStatistics = new ArrayList<>();
Review comment:
```java
return Arrays.asList(
new StatisticsHolder<>(statsProvider.getRowCount(),
TableStatisticsKind.EST_ROW_COUNT),
new StatisticsHolder<>(Boolean.TRUE,
TableStatisticsKind.HAS_DESCRIPTIVE_STATISTICS)
);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
