arina-ielchiieva commented on a change in pull request #1810: DRILL-7271:
Refactor Metadata interfaces and classes to contain all needed information for
the File based Metastore
URL: https://github.com/apache/drill/pull/1810#discussion_r296682838
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScanWithMetadata.java
##########
@@ -666,27 +733,66 @@ protected void filterTableMetadata(FilterPredicate
filterPredicate, Set<SchemaPa
}
/**
- * Produces filtering of metadata at partition level.
+ * Produces filtering of metadata at segment level.
Review comment:
I did not see any description in Jira or in the PR how come we switched from
patriots to segment levels... It would be good to document this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
