arina-ielchiieva commented on a change in pull request #1815: DRILL-6711: Use jitpack repository for Drill Calcite project artifacts instead of repository.mapr.com URL: https://github.com/apache/drill/pull/1815#discussion_r297603032
########## File path: docs/dev/Calcite.md ########## @@ -0,0 +1,26 @@ +# Drill-specific commits in Apache Calcite + +Currently, Drill uses Apache Calcite with additional changes, required for Drill. All the commits were left after +update from Calcite `1.4.0` to Calcite `1.15.0` and weren't merged to the Calcite's master yet. + +List of Jiras with Drill-specific commits: + +|Jira|Summary|The reason why it wasn't merged| +|----|-------|-------------------------------| +|[CALCITE-2018](https://issues.apache.org/jira/browse/CALCITE-2018)|Queries failed with AssertionError: rel has lower cost than best cost of subset|Pull request with the fix was created ([PR-552](https://github.com/apache/calcite/pull/552)), but an issue which blocks it was found and wasn't resolved yet: [CALCITE-2166](https://issues.apache.org/jira/browse/CALCITE-2166).| +|[CALCITE-2087](https://issues.apache.org/jira/browse/CALCITE-2087)|Add new method to ViewExpander interface to allow passing SchemaPlus.|Pull request into Apache Calcite was created, but it was declined. See conversation in Jira.| +|[CALCITE-1178](https://issues.apache.org/jira/browse/CALCITE-1178)|Allow SqlBetweenOperator to compare DATE and TIMESTAMP|SQL spec does not allow to compare datetime types if they have different <primary datetime field>s. Therefore Calcite community won’t accept these changes. Similar issues were reported in [CALCITE-2829](https://issues.apache.org/jira/browse/CALCITE-2829) and in [CALCITE-2745](https://issues.apache.org/jira/browse/CALCITE-2745)| + +# Drill-Calcite repository + +Repository with source code is placed [here](https://github.com/vvysotskyi/drill-calcite). For backward +compatibility, some previously used by Drill branches were pushed to this repo. + +For the case when committer should be provided with required rights, please notify repository owner about that. + +# Process of updating Calcite version + +- Push required changes to the branch, or create required a branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which weren't merged to Apache Calcite master if it wasn't discussed broadly.* Review comment: ```suggestion - Push required changes to the existing branch, or create new branch. *Though this repository contains Drill specific commits, it is forbidden to add additional specific commits which were not merged to Apache Calcite master if it wasn't discussed in Drill community first.* ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
