arina-ielchiieva commented on issue #1813: DRILL-7306: Disable schema-only batch for new scan framework URL: https://github.com/apache/drill/pull/1813#issuecomment-506972377 @paul-rogers When running tests there are unit and functional test failures. Please run full unit tests suit locally before making the PR, Travis does not do that. UNIT TESTS ``` [INFO] Running org.apache.drill.exec.TestEmptyInputSql 05:53:50.840 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 B(1.0 MiB), h: 6.3 MiB(863.9 MiB), nh: 32 B(324.6 MiB)): testQueryEmptyCsv(org.apache.drill.exec.TestEmptyInputSql) java.lang.Exception: Expected and actual numbers of columns do not match. at org.apache.drill.test.DrillTestWrapper.compareSchemaOnly(DrillTestWrapper.java:486) ~[test-classes/:1.17.0-SNAPSHOT] at org.apache.drill.test.DrillTestWrapper.run(DrillTestWrapper.java:163) ~[test-classes/:1.17.0-SNAPSHOT] at org.apache.drill.exec.TestEmptyInputSql.testQueryEmptyCsv(TestEmptyInputSql.java:222) ~[test-classes/:na] at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161]. ``` FUNCTIONAL TESTS ``` Data Verification Failures: Query: /root/drillAutomation/drill-test-framework/framework/resources/Functional/limit0/union_all/prq_union_all/data/emptyLHS_CSV.q SELECT cast(columns[0] as int) FROM `emptyFiles/empty_1.csv` UNION ALL SELECT col1 FROM notEmpty_csv_v Baseline: /root/drillAutomation/drill-test-framework/framework/resources/Functional/limit0/union_all/prq_union_all/data/emptyLHS_CSV.e Expected number of rows: 10 Actual number of rows from Drill: 10 Number of matching rows: 0 Number of rows missing: 10 Number of rows unexpected: 10 These rows are not expected (first 10): null These rows are missing (first 10): 1 (1 occurence(s)) 2 (1 occurence(s)) 3 (1 occurence(s)) 4 (1 occurence(s)) 5 (1 occurence(s)) 6 (1 occurence(s)) 7 (1 occurence(s)) 8 (1 occurence(s)) 9 (1 occurence(s)) 10 (1 occurence(s)) ``` Please fix the failures and rebase on the latest master. Also when I was cherry-picking DRILL-7306 & DRILL-6951 there were conflicts. You can consider creating merge branch with commits for these Jiras and resolve the conflicts to ease merge process.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
