vvysotskyi commented on a change in pull request #1820: DRILL-7307: casthigh
for decimal type can lead to the issues with VarDecimalHolder
URL: https://github.com/apache/drill/pull/1820#discussion_r300470817
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
##########
@@ -1111,6 +1112,10 @@ public HoldingContainer
visitConvertExpression(ConvertExpression e, ClassGenerat
}
}
+ private interface GetHolderCall {
Review comment:
Could you please add a more proper name to this interface, add Javadoc and
move it above inner classes declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
