vvysotskyi commented on a change in pull request #1821:  DRILL-7315: Revise 
precision and scale order in the method arguments
URL: https://github.com/apache/drill/pull/1821#discussion_r300695697
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/types/Types.java
 ##########
 @@ -549,7 +549,7 @@ public static MajorType withPrecision(final MinorType 
type, final DataMode mode,
     return 
MajorType.newBuilder().setMinorType(type).setMode(mode).setPrecision(precision).build();
   }
 
-  public static MajorType withScaleAndPrecision(final MinorType type, final 
DataMode mode, final int scale, final int precision) {
+  public static MajorType withScaleAndPrecision(MinorType type, DataMode mode, 
int precision, int scale) {
 
 Review comment:
   Thanks, done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to