paul-rogers edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map<K,V> URL: https://github.com/apache/drill/pull/1829#issuecomment-515716369 Looks like lots of work went into adapting the old-school complex readers and writers for this new type, but the newer column readers and writers don't have support. As a result, folks who want to use this feature need to use the old-style readers; the newer style "EVF" won't be usable for true maps. Also, there is no "RowSet" support. So, tests that want to include a true map must, it seems, use our older test framework. If so, then that framework should not longer be deprecated, but may in fact be the preferred framework for any query that might include a true map. Not sure that this is helpful longer term (there was a reason we moved to the new framework), but it is worth calling out that this PR pushes us in that direction. While undoubtedly this implementation is exactly what one particular use case needs; I do wonder at the wisdom of creating pools of partially supported features that reflect which sponsor pays for the work. Said another way, it would be very helpful, to encourage folks to create new readers, if the true map PR included EVF support.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
