paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515794219 @arina-ielchiieva, thank your for your review on a weekend! Addressed the minor comments. This PR tackles only missing container and record count values. These errors were found by enabling the "batch validator" and adding many rigorous consistency checks. The validator also checks vectors: there are hundreds of errors in which counts are wrong, offset vectors are invalid and so on. Those will be done as a separate PR to avoid overwhelming the reviewer (or myself.) This is also why the batch validator itself is not part of this PR: it would complain about the invalid vectors. In starting on the vector fixes, many of these same operators are fixed again, along with a few others. An earlier comment mentioned that I saw a number of RPC errors due to what seems like a race condition in closing allocators. Oddly, it turns out that Travis did not see those errors, but instead found an out-of-bounds error. When tests run under Maven, we turn on checking of vector bounds. I discovered that bounds checks are turned off in the IDE, which is why I didn't catch the issue. I'll follow up with another commit for that fix. (That commit will also turn on bounds checking if assertions are enabled so that bounds checking occurs in IDE test runs.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
