arina-ielchiieva commented on a change in pull request #1835: DRILL-7337: Add
vararg UDFs support
URL: https://github.com/apache/drill/pull/1835#discussion_r310384111
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java
##########
@@ -298,11 +368,19 @@ public int getParamCount() {
}
public boolean isConstant(int i) {
- return attributes.getParameters()[i].isConstant();
+ return getAttributeParameter(i).isConstant();
+ }
+
+ public ValueReference getAttributeParameter(int i) {
Review comment:
Please add java doc thus there will be no need in the comment in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
