arina-ielchiieva edited a comment on issue #1841: Drill-7344: Add Geo-IP 
Functions
URL: https://github.com/apache/drill/pull/1841#issuecomment-520781600
 
 
   @cgivre if you want to include PR #1840 and #1841 into the upcoming release, 
please rework these PRs to have proper error handling, to comply with Drill 
coding style etc. There were similar PRs which undergo the review and have been 
merged, you can take a look at the code and make appropriate changes. I think 
it's more reasonable than making code reviewers pointing at the same issues 
over and over again :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to