cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions URL: https://github.com/apache/drill/pull/1841#issuecomment-520893562 The reason I'd suggest this is that there are free functions, which are in widespread use, and there are also paid versions with the same functionality. If we moved it to the classpath, a user could choose whether they want to use the free or paid versions of these repositories. -- C > On Aug 13, 2019, at 11:49 AM, Arina Ielchiieva <[email protected]> wrote: > > I think brings too much overhead, if user needs these functions he can include jar with functions and files in the classpath. Having functions that require some special data in the classpath to be working is odd. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/drill/pull/1841?email_source=notifications&email_token=ABKB7PQTEP34VOBGMVWG5XDQELJZJA5CNFSM4IK5LY7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GDDII#issuecomment-520892833>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKB7PQAL7UD7CZV5SV6XF3QELJZJANCNFSM4IK5LY7A>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
