arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move
RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314670539
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.java
##########
@@ -41,13 +38,19 @@ public AbstractRowSet(VectorContainer container,
TupleMetadata schema) {
}
@Override
- public VectorAccessible vectorAccessible() { return container(); }
+ public VectorAccessible vectorAccessible() {
Review comment:
I think we should enforce such checkstyle. Taking into account that most of
IDE can compress such methods automatically plus many other projects follow the
same pattern. Personally, I was following such code style as well. @vvysotskyi
could you please create Jira?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
