vvysotskyi commented on a change in pull request #1844: DRILL-7326: Support 
repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r315674007
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
 ##########
 @@ -292,7 +293,12 @@ private Type getType(MaterializedField field) {
         }
         return new GroupType(dataMode == DataMode.REPEATED ? 
Repetition.REPEATED : Repetition.OPTIONAL, field.getName(), types);
       case LIST:
-        throw new UnsupportedOperationException("Unsupported type " + 
minorType);
+        MaterializedField elementField = field.getChildren().iterator().next();
 
 Review comment:
   I assume you are expecting here `$data$` field, but in some cases, list 
filed may also have `$offsets$` child. Should we obtain a child with the 
required name here (`BaseRepeatedValueVector.DATA_VECTOR_NAME`)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to