agozhiy commented on issue #1845: DRILL-7353: Wrong driver class is written to 
the java.sql.Driver
URL: https://github.com/apache/drill/pull/1845#issuecomment-523075544
 
 
   From the [shade plugin 
documentation:](http://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html)
   > From a logical perspective, includes are processed before excludes, thus 
it's possible to use an include to collect a set of files from the archive then 
use excludes to further reduce the set.
   
   So we cannot just exclude everything and then include a specific resource. 
Instead, we should exclude all interfering ones, that is the approach used in 
the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to