KazydubB commented on a change in pull request #1844: DRILL-7326: Support
repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r317110426
##########
File path:
exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java
##########
@@ -96,7 +96,7 @@ private void initFieldWriters() throws IOException {
public static abstract class FieldConverter {
protected static final String LIST = "list";
- protected static final String ELEMENT = "element";
+ public static final String ELEMENT = "element";
Review comment:
I think it is better to move the definition of `ELEMENT` and `LIST` to
`ParquetRecordWriter` because `FieldConverter` is used for other (csv, json
etc.) formats as well and the group names are needed for Parquet only and it's
up to writer to "decide" how to write a file. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
